Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass event created timestamp correctly to cache #124297

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Pass event created timestamp correctly to cache #124297

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7612858
Pass event created timestamp correctly to cache
hshiina Apr 12, 2024
dbc4734
Update global cache timestamp more frequently
hshiina May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/kubelet/pleg/evented.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,7 +264,7 @@ func (e *EventedPLEG) processCRIEvents(containerEventsResponseCh chan *runtimeap
}
shouldSendPLEGEvent = true
} else {
if e.cache.Set(podID, status, err, time.Unix(event.GetCreatedAt(), 0)) {
if e.cache.Set(podID, status, err, time.Unix(0, event.GetCreatedAt())) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hshiina great catch! Thank you!
/lgtm

shouldSendPLEGEvent = true
}
}
Expand Down