-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Azure storage provider as azure://
#3702
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Khanh Chuong Le <leduc89@gmail.com> (cherry picked from commit 45d282d)
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: leduckhc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
@leduckhc: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @yuzisun |
return azureUriParts{ | ||
serviceUrl: string(HTTPS) + serviceUrl, | ||
containerName: containerName, | ||
prefix: prefix, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to name it as blob to improve the readability.
There are some other comments in this closed PR as well. |
Signed-off-by: Khanh Chuong Le leduc89@gmail.com
(cherry picked from commit 45d282d)
What this PR does / why we need it:
Add Azure storage provider to download multiple blobs in virtual directory
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #3691
Type of changes
Please delete options that are not relevant.
Feature/Issue validation/testing:
Please describe the tests that you ran to verify your changes and relevant result summary. Provide instructions so it can be reproduced.
Please also list any relevant details for your test configuration.
Unit and mock tests
Logs
Special notes for your reviewer:
Checklist:
Release note:
Re-running failed tests
/rerun-all
- rerun all failed workflows./rerun-workflow <workflow name>
- rerun a specific failed workflow. Only one workflow name can be specified. Multiple /rerun-workflow commands are allowed per comment.