-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes deprecated types (and ListSchemaConfig) #8766
Open
dcousens
wants to merge
11
commits into
main
Choose a base branch
from
less-deprecated-types
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2fdf468:
|
dcousens
force-pushed
the
less-deprecated-types
branch
3 times, most recently
from
August 14, 2023 01:43
dc88ae4
to
1135bdd
Compare
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Josh Calder <josh.calder@thinkmill.com.au> Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
Co-authored-by: mitchellhamilton <mitchell@hamil.town>
Co-authored-by: Daniel Cousens <dcousens@users.noreply.github.com>
…ds (#8698) Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
Co-authored-by: Daniel Cousens <413395+dcousens@users.noreply.github.com>
dcousens
force-pushed
the
less-deprecated-types
branch
from
September 10, 2023 23:48
1135bdd
to
2fdf468
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request removes the unused first type parameter from
ListConfig
,ListAdminUIConfig
types, and from thelist
andgroup
function types.This should allow developers to now use
list<Lists.Post>
instead oflist<any, Lists.Post
>.This pull request also removes the
ListSchemaConfig
type, useConfig['lists']' from
.keystone/types(or
KeystoneConfig['lists']from
@keystone-6/core/types`).Lastly, this pullr equest renames
Lists.*.TypeInfo.all
toLists.*.TypeInfo.SchemaTypeInfo
, to verbosely show where any circular types might be appearing from. (suspect for #8749)