Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Derp204 dockernetworking #1768

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Derp204 dockernetworking #1768

wants to merge 5 commits into from

Conversation

TotoTheDragon
Copy link
Contributor

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

tomtom5152 and others added 4 commits February 15, 2024 17:15
@tomtom5152 @kradalby
Add DERP generate_204 endpoint for captive portal detection.
16766ae
@kradalby
initial work on integration tests
ed1671e 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
add gh for new testcase
afa064f 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@kradalby
listen for generate_204 on 80
61fe21d 
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
@Orhideous
Copy link
Contributor

Ran this branch in a fairly simple setup for week or so, no problems with this feature for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanfont juanfont Awaiting requested review from juanfont juanfont is a code owner

@kradalby kradalby Awaiting requested review from kradalby kradalby is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@TotoTheDragon @Orhideous @tomtom5152 @kradalby