Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.2] Show show a warning when there are due tasks #43491

Open
wants to merge 13 commits into
base: 5.2-dev
Choose a base branch
from

Conversation

zero-24
Copy link
Contributor

@zero-24 zero-24 commented May 19, 2024

Summary of Changes

Show next run, show list by next run and show a warning when there are due tasks

Testing Instructions

  • Load the scheduled tasks
  • Notice the ordeing by title and the missing Next Run field from the list
  • Apply this patch
  • Open that page again
  • Confrim that the Next Run field is there as well as its orderd by that field so the next task to run will be shown first

image

  • Go to the database -> #__scheduler_tasks take one task and set the next_execution date to someting in the past
    image

  • Reload the scheduled tasks list and notice the message that comes up
    image

  • Use the "Test " button

  • Notice the message is gone, it will come up of course as soon as there is another due task which is not run

Actual result BEFORE applying this Pull Request

No way to detect not run tasks or get to know the next tasks to trigger.

Expected result AFTER applying this Pull Request

  1. Warning when there are due tasks
  2. Option to show the next time a task should run
  3. Default ordeing to show the next task to run first

Link to documentations

Please select:

@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators PR-5.1-dev labels May 19, 2024
Co-authored-by: Quy <quy@nomonkeybiz.com>
@Quy
Copy link
Contributor

Quy commented May 21, 2024

On initial load of list view, sort indicator does not match dropdown.

43491

@zero-24
Copy link
Contributor Author

zero-24 commented May 22, 2024

Please try again @Quy

@richard67
Copy link
Member

@zero-24 Is this a bug fix or a new feature?
If bug fix, then the bug may also apply to 4.4-dev and so should be fixed there, too (or only there and later be merged up to 5.1-dev). The bug might not be as visible on the 4.4-dev branch as it is here because in 4.4 we did not use the task scheduler for cyclic core stuff, but it might apply also there.
But if new feature: Shouldn't it be made for 5.2-dev?

@zero-24 zero-24 changed the base branch from 5.1-dev to 5.2-dev June 2, 2024 18:54
@zero-24 zero-24 requested a review from laoneo as a code owner June 2, 2024 18:54
@zero-24 zero-24 changed the title [5.1] Show show a warning when there are due tasks [5.2] Show show a warning when there are due tasks Jun 2, 2024
@joomla-cms-bot joomla-cms-bot added NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.2-dev labels Jun 2, 2024
@zero-24
Copy link
Contributor Author

zero-24 commented Jun 2, 2024

Moved to 5.2 looking forward to tests on this PR so it can be merged.

@joomla-cms-bot joomla-cms-bot removed the NPM Resource Changed This Pull Request can't be tested by Patchtester label Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants