[5.2] Deprecate HTMLHelper::script(), HTMLHelper::stylesheet(), extend lifetime for Document style/script methods #43396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue # .
Summary of Changes
Deprecate
HTMLHelper::script()
,HTMLHelper::stylesheet()
.Extend lifetime for
Document
style/script methods, because they cannot be removed beforeHTMLHelper::script()
,HTMLHelper::stylesheet()
.Add a new method
HTMLHelper::mediaPath()
, because we still need to lookup for overides.Kind of temporary solution, until someone will come up with improvements to our media override API.
Testing Instructions
Apply patch. Make sure all works as before.
Add
media/templates/administrator/atum/css/user.css
to atum template, and make sure it still works.Actual result BEFORE applying this Pull Request
Works
Expected result AFTER applying this Pull Request
Works
Link to documentations
Please select: