-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add start and end parameters #4352
base: main
Are you sure you want to change the base?
Conversation
@pavolloffay @yurishkuro could u help with this PR? |
Signed-off-by: alburthoffman <alburthoffman@gmail.com>
15d3c5e
to
7cf9821
Compare
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated IDL & regenerated typed
@@ -61,6 +61,13 @@ type Reader interface { | |||
FindTraceIDs(ctx context.Context, query *TraceQueryParameters) ([]model.TraceID, error) | |||
} | |||
|
|||
// TraceIDQueryParameters contains parameters of a trace id query. | |||
type TraceIDQueryParameters struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is rather unwieldy name, can we shorted to TraceIDQuery ?
@@ -36,7 +36,7 @@ type Reader interface { | |||
// GetTrace retrieves the trace with a given id. | |||
// | |||
// If no spans are stored for this trace, it returns ErrTraceNotFound. | |||
GetTrace(ctx context.Context, traceID model.TraceID) (*model.Trace, error) | |||
GetTrace(ctx context.Context, query *TraceIDQueryParameters) (*model.Trace, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetTrace(ctx context.Context, query *TraceIDQueryParameters) (*model.Trace, error) | |
GetTrace(ctx context.Context, query TraceIDQueryParameters) (*model.Trace, error) |
The query is required, no reason to pass via pointer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated IDL & regenerated typed
The Proto file changes that include time stamps have been merged separately. This needs to be rebased. |
Which problem is this PR solving?
Resolves 4150
Short description of the changes
allow optional time parameters when querying trace by id