Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API/Gateway listens on both IPv4 and IPv6 #9788

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Rishi556
Copy link

@Rishi556 Rishi556 commented Apr 2, 2023

Node.JS 18 stopped reordering DNS to have IPv4 addresses be first(nodejs/node#39987), and this causes some issues since Kubo isn't listening for API requests on [::1]. To fix this, we change the default config to listen on IPv6 and IPv4 for both api and gateway. This PR will resolve #9637.

@Rishi556 Rishi556 changed the title API/Gateway listens on both IPv4 and IPv6 as well API/Gateway listens on both IPv4 and IPv6 Apr 2, 2023
@guseggert
Copy link
Contributor

This LGTM for new installations but existing ones will continue to use the old defaults unless there's a config migration, do you think this should include one?

@Jorropo
Copy link
Contributor

Jorropo commented Apr 3, 2023

I think we should include one.

@Rishi556
Copy link
Author

Rishi556 commented Apr 3, 2023

Is there a PR with a config migration example that I can take a look at to add that into this PR?

@Jorropo
Copy link
Contributor

Jorropo commented Apr 4, 2023

@Rishi556 https://github.com/ipfs/fs-repo-migrations/tree/master/fs-repo-12-to-13

@Rishi556 Rishi556 requested a review from a team as a code owner April 16, 2023 06:04
@hacdias
Copy link
Member

hacdias commented Apr 16, 2023

@Rishi556 I think we're still waiting for the repo migration PR, right @Jorropo?

@Jorropo
Copy link
Contributor

Jorropo commented Apr 16, 2023

Yes

@Rishi556
Copy link
Author

Yup, hopefully I'll be able to get to it sometime this week.

@BigLep
Copy link
Contributor

BigLep commented May 11, 2023

@Rishi556 : just checking to see if this is something you'll still be able to tackle?

@Rishi556
Copy link
Author

@BigLep I think so, just have gotten very busy and will continue to be until this weekend, but I might finally have some time after that.

@lidel lidel mentioned this pull request May 23, 2023
3 tasks
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid this is blocked by bugs listed in #9637 (comment) – once resolved, we can get back to this PR.

@lidel lidel added the status/blocked Unable to be worked further until needs are met label May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/blocked Unable to be worked further until needs are met
Projects
No open projects
Status: 🛑 Blocked
Development

Successfully merging this pull request may close these issues.

Start API on both IPv4 and IPv6
6 participants