Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSB-445 feature: storing user last login timestamp #4074

Merged
merged 7 commits into from
May 27, 2024
Merged

HSB-445 feature: storing user last login timestamp #4074

merged 7 commits into from
May 27, 2024

Conversation

mirarifhasan
Copy link
Contributor

@mirarifhasan mirarifhasan commented May 19, 2024 •
edited

Closes HSB-444

Description

This PR introduces the ability to store the user's last login timestamp in hoppscotch-backend package (in the user table). lastLoggedOn is the property to access the data. This value can be nullable for previous data.

Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

Additional Information

Nil

@mirarifhasan mirarifhasan requested a review from balub May 19, 2024 17:12
@mirarifhasan mirarifhasan self-assigned this May 19, 2024
@mirarifhasan mirarifhasan marked this pull request as ready for review May 19, 2024 17:12
@mirarifhasan mirarifhasan removed the request for review from ankitsridhar16 May 19, 2024 17:12
@mirarifhasan mirarifhasan changed the title HSB-444 feature: storing user last login timestamp HSB-445 feature: storing user last login timestamp May 19, 2024
@JoelJacobStephen JoelJacobStephen mentioned this pull request May 20, 2024
Draft
4 tasks
@balub balub self-requested a review May 20, 2024 07:28
balub
balub requested changes May 27, 2024
View reviewed changes
Copy link
Member

@balub balub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are not calling updateUserLastLoggedOn in the strategies for the SSO providers. It currently does not update the last logged in when a user logs in via any SSO provider.

balub
balub approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@balub balub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@balub balub merged commit f4f3fdf into next May 27, 2024
@balub balub deleted the feat/user-last-login-time branch May 27, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balub balub balub approved these changes

Assignees

@mirarifhasan mirarifhasan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mirarifhasan @balub