Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run generators ctrl-manifests and ctrl-generate #4009

Merged
merged 1 commit into from
May 22, 2024
Merged

run generators ctrl-manifests and ctrl-generate #4009

merged 1 commit into from
May 22, 2024

Conversation

jm96441n
Copy link
Member

Changes proposed in this PR

How I've tested this PR

How I expect reviewers to test this PR

Checklist

@jm96441n jm96441n added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-backport signals that a PR will not contain a backport label labels May 20, 2024
nathancoleman
nathancoleman approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@nathancoleman nathancoleman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this cleans things up and results in no diff when running make ctrl-manifests and make ctrl-generate

@jm96441n jm96441n merged commit 1cafeb8 into main May 22, 2024
47 of 57 checks passed
@jm96441n jm96441n deleted the run-generators branch May 22, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathancoleman nathancoleman nathancoleman approved these changes

Assignees
No one assigned
Labels
pr/no-backport signals that a PR will not contain a backport label pr/no-changelog PR does not need a corresponding .changelog entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jm96441n @nathancoleman