NET-6704 Modify-server-acl-init-role #3957
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahalsmiller
added
pr/no-changelog
sarahalsmiller
requested review from
a team,
nathancoleman and
missylbytes
and removed request for
a team
sarahalsmiller
force-pushed
the
NET-6704-Modify-server-acl-init-role-to-specify-apiGroups-as-core-
branch
from
9488d15
to
1ef5aef
Compare
|
overall LGTM but I think we should probably add a changelog here |
sarahalsmiller
force-pushed
the
NET-6704-Modify-server-acl-init-role-to-specify-apiGroups-as-core-
branch
from
3a0be38
to
1ef5aef
Compare
sarahalsmiller
force-pushed
the
NET-6704-Modify-server-acl-init-role-to-specify-apiGroups-as-core-
branch
from
1ef5aef
to
c94c45a
Compare
sarahalsmiller
force-pushed
the
NET-6704-Modify-server-acl-init-role-to-specify-apiGroups-as-core-
branch
from
87739e5
to
96214cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR
How I've tested this PR
How I expect reviewers to test this PR
Checklist