-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce tsh binary size #41743
Merged
Merged
Reduce tsh binary size #41743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
force-pushed
the
tross/tsh_auth
branch
from
May 18, 2024 17:48
1faf16b
to
85d846a
Compare
rosstimothy
added
no-changelog
Indicates that a PR does not require a changelog entry
backport/branch/v14
backport/branch/v15
labels
May 18, 2024
rosstimothy
force-pushed
the
tross/tsh_auth
branch
from
May 18, 2024 18:37
85d846a
to
fbabc64
Compare
Refactors the terminal stream code in lib/web into a subpackage so that tsh no longer depends on the entire lib/web package.
Refactors invalid credentials errors and helpers into lib/auth/authclient so that tsh no longer imports lib/auth directly.
rosstimothy
force-pushed
the
tross/tsh_auth
branch
3 times, most recently
from
May 20, 2024 19:51
7a55d92
to
1e19e38
Compare
rosstimothy
force-pushed
the
tross/tsh_auth
branch
from
May 20, 2024 19:54
1e19e38
to
1e08571
Compare
Merged
github-actions
bot
added
desktop-access
size/sm
tsh
tsh - Teleport's command line tool for logging into nodes running Teleport.
labels
May 20, 2024
probakowski
approved these changes
May 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
@zmb3 can I get a FTD exclusion? |
/excludeflake * |
zmb3
approved these changes
May 21, 2024
public-teleport-github-review-bot
bot
removed the request for review
from ibeckermayer
May 21, 2024 18:12
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
May 21, 2024
* Remove lib/web dependency from tsh Refactors the terminal stream code in lib/web into a subpackage so that tsh no longer depends on the entire lib/web package. * Remove lib/auth dependency from tsh Refactors invalid credentials errors and helpers into lib/auth/authclient so that tsh no longer imports lib/auth directly. * fix find-replace typos
rosstimothy
added a commit
that referenced
this pull request
May 23, 2024
* Remove lib/web dependency from tsh Refactors the terminal stream code in lib/web into a subpackage so that tsh no longer depends on the entire lib/web package. * Remove lib/auth dependency from tsh Refactors invalid credentials errors and helpers into lib/auth/authclient so that tsh no longer imports lib/auth directly. * fix find-replace typos
rosstimothy
added a commit
that referenced
this pull request
May 23, 2024
* Remove lib/web dependency from tsh Refactors the terminal stream code in lib/web into a subpackage so that tsh no longer depends on the entire lib/web package. * Remove lib/auth dependency from tsh Refactors invalid credentials errors and helpers into lib/auth/authclient so that tsh no longer imports lib/auth directly. * fix find-replace typos
rosstimothy
added a commit
that referenced
this pull request
May 23, 2024
* Remove lib/web dependency from tsh Refactors the terminal stream code in lib/web into a subpackage so that tsh no longer depends on the entire lib/web package. * Remove lib/auth dependency from tsh Refactors invalid credentials errors and helpers into lib/auth/authclient so that tsh no longer imports lib/auth directly. * fix find-replace typos
rosstimothy
added a commit
that referenced
this pull request
May 23, 2024
* Remove lib/web dependency from tsh Refactors the terminal stream code in lib/web into a subpackage so that tsh no longer depends on the entire lib/web package. * Remove lib/auth dependency from tsh Refactors invalid credentials errors and helpers into lib/auth/authclient so that tsh no longer imports lib/auth directly. * fix find-replace typos
rosstimothy
added a commit
that referenced
this pull request
May 24, 2024
* Remove lib/web dependency from tsh Refactors the terminal stream code in lib/web into a subpackage so that tsh no longer depends on the entire lib/web package. * Remove lib/auth dependency from tsh Refactors invalid credentials errors and helpers into lib/auth/authclient so that tsh no longer imports lib/auth directly. * fix find-replace typos
rosstimothy
added a commit
that referenced
this pull request
May 24, 2024
* Remove lib/web dependency from tsh Refactors the terminal stream code in lib/web into a subpackage so that tsh no longer depends on the entire lib/web package. * Remove lib/auth dependency from tsh Refactors invalid credentials errors and helpers into lib/auth/authclient so that tsh no longer imports lib/auth directly. * fix find-replace typos
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 24, 2024
* Remove lib/web dependency from tsh Refactors the terminal stream code in lib/web into a subpackage so that tsh no longer depends on the entire lib/web package. * Remove lib/auth dependency from tsh Refactors invalid credentials errors and helpers into lib/auth/authclient so that tsh no longer imports lib/auth directly. * fix find-replace typos
github-merge-queue bot
pushed a commit
that referenced
this pull request
May 24, 2024
* Remove lib/web dependency from tsh Refactors the terminal stream code in lib/web into a subpackage so that tsh no longer depends on the entire lib/web package. * Remove lib/auth dependency from tsh Refactors invalid credentials errors and helpers into lib/auth/authclient so that tsh no longer imports lib/auth directly. * fix find-replace typos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport/branch/v14
backport/branch/v15
desktop-access
no-changelog
Indicates that a PR does not require a changelog entry
size/sm
tsh
tsh - Teleport's command line tool for logging into nodes running Teleport.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes lib/auth and cloud.google.com/go/compute/apiv1 from the tsh dependency tree to reduce tsh by ~15-20MB.
This was done by two changes: