-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add metadata to public transportation legs. #2708
base: master
Are you sure you want to change the base?
Conversation
Add: - route_type - route_url - route_short_name - route_long_name
Let me bump this PR. Other metadata I added is the line's name ( Currently, I use these data for my research. |
As a user of graphhopper I find this a very useful feature and would appreciate it, if this would get merged / the functionality be implemented. |
I was searching for this feature because this is the main reason why I'm not using graphhopper right now! please merge this!! |
@karussell @michaz @easbar, do you have any opinion on this? |
Well. I would say it's not so much hiding the information, as it is not reproducing the full I mean, if
@abelcervantes Wait, really, these exact fields not being on the response is the main reason you are not using GraphHopper right now? |
String routeShortName = ""; | ||
String routeLongName = ""; | ||
Route route = gtfsFeed.routes.get(tripDescriptor.getRouteId()); | ||
if (route != null) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be null though?
Another way is to add a query parameter similar to the "details" parameter of the classical route. |
Yes, basically because it was a mandatory requirement for most of our customers. We had to move to OpenTripPlanner. |
Agree with @michaz , other fields like route_color and route_text_color among others should be included. In our experience, many customers like to see this kind of information on the UI. |
I already suggested a PR, which is now closed. You can still check my post on the forum.
This one is cleaner and passes all the tests.
Let me know if something is missing.