Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: MediaPlaylist with discontinuities should not ignore maps #154

Open
wants to merge 35 commits into
base: master
Choose a base branch
from

Conversation

vish91
Copy link

@vish91 vish91 commented Nov 25, 2019

MediaPlaylist with discontinuities should not ignore segment maps
https://tools.ietf.org/html/draft-pantos-http-live-streaming-23#section-4.3.2.5
https://developer.apple.com/documentation/http_live_streaming/hls_authoring_specification_for_apple_devices 8.20

MediaPlaylist with default Map and discontinuities should always have segment Maps, referring to the media initialization section after it ( be it content or ads or even if it is same as the DefaultMap )

Example:
today we get

#EXT-X-VERSION:5
#EXT-X-MAP:URI="https://example.com/content-init.mp4",BYTERANGE=1024000@1048576
#EXT-X-MEDIA-SEQUENCE:0
#EXT-X-TARGETDURATION:6
#EXTINF:5.000,
test01.mp4
#EXT-X-DISCONTINUITY
#EXTINF:6.000,
test02.mp4
#EXTINF:6.000,
test03.mp4
#EXT-X-DISCONTINUITY
#EXTINF:6.000,
test04.mp4
#EXTINF:6.000,
test05.mp4

instead we should expect:

#EXT-X-VERSION:5
#EXT-X-MAP:URI="https://example.com/content-init.mp4",BYTERANGE=1024000@1048576
#EXT-X-MEDIA-SEQUENCE:0
#EXT-X-TARGETDURATION:6
#EXTINF:5.000,
test01.mp4
#EXT-X-DISCONTINUITY
#EXT-X-MAP:URI="https://segmentencoded.com/ad-init.mp4",BYTERANGE=1024000@1048576
#EXTINF:6.000,
test02.mp4
#EXTINF:6.000,
test03.mp4
#EXT-X-DISCONTINUITY
#EXT-X-MAP:URI="https://example.com/content-init.mp4",BYTERANGE=1024000@1048576
#EXTINF:6.000,
test04.mp4
#EXTINF:6.000,
test05.mp4

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 75.58% when pulling 08b2d91 on zencoder:master into 2ce07e6 on grafov:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 75.58% when pulling 08b2d91 on zencoder:master into 2ce07e6 on grafov:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 75.58% when pulling 08b2d91 on zencoder:master into 2ce07e6 on grafov:master.

@vish91
Copy link
Author

vish91 commented May 12, 2020

@grafov or @leikao would appreciate if someone can review and merge this please

soldiermoth and others added 23 commits October 7, 2020 12:59
* support custom tag decode/encode

* add unit tests

* go fmt

* add go.mod

* add writer tests, breakup custom interface

* update readme

* add comments to exports

* parse custom tags first

* update CustomDecoder.Segment to CustomDecoder.SegmentTag

* Add badge of godoc.org for the awesome-go

* Fix formatting with gofmt

Also copyrights updated.

Refs to issue grafov#151.

* Fix comments by golint recommendations

Refs to issue grafov#151.

* Simplify with gofmt

Refs to issue grafov#151.

* Fix comments accordingly with golint advices

Refs to issue grafov#151.

* Integrate with deepsource.io

It bring us more code quality analyzers.
Refs grafov#151.

* Add deepsource.io badge

Refs grafov#151.

* Add awesome-go badge

Refs to issue grafov#151.

* Try vanity import to work w/ travis

* remove coveralls from fork

Co-authored-by: Matthew Neil <mneil@mneil-retina-2016.vidmark.local>
Co-authored-by: Lei Gao <lei@gyx.pub>
Co-authored-by: Alexander I.Grafov <grafov@gmail.com>
Fernando Partida and others added 9 commits December 30, 2021 11:06
[Deliver-2341] Add new fields for Image Playlist
Co-authored-by: whitesource-for-github-com[bot] <50673670+whitesource-for-github-com[bot]@users.noreply.github.com>
* Support for EXT-X-CUE-OUT and EXT-X-CUE-IN tags

* Support empty segments and unit tests

* Remove old unit test

* Error handling
Add option to encode MAP tag before KEY tag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants