SceneQueryRunner: Detect new variable values when cloned #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelo
added
minor
torkelo
commented
May 9, 2024
tsconfig.json
Outdated
Comment on lines
7
to
18
| "rootDirs": [ | ||
| "." | ||
| ] | ||
| "rootDirs": ["."] | ||
| }, | ||
| "exclude": [ | ||
| "dist/**/*" | ||
| ], | ||
| "include": [ | ||
| "utils/**/*.ts*", | ||
| "src/**/*.ts*" | ||
| ], | ||
| "exclude": ["dist/**/*"], | ||
| "include": ["utils/**/*.ts*", "src/**/*.ts*"], | ||
| "ts-node": { | ||
| "compilerOptions": { | ||
| "isolatedModules": false, | ||
| "module": "commonjs" | ||
| } | ||
| } | ||
| } No newline at end of file | ||
| } |
There was a problem hiding this comment.
this is just a vs code format, we need to update this file, we do not run typescript strict mode , but will do in separate PR
9 tasks
…ner-detect-new-values
dprokop
approved these changes
May 10, 2024
| @@ -439,6 +439,8 @@ export class SceneQueryRunner extends SceneObjectBase<QueryRunnerState> implemen | |||
| clone['_layerAnnotations'] = this._layerAnnotations.map((frame) => ({ ...frame })); | |||
| } | |||
|
|
|||
| clone['_variableValueRecorder'] = this._variableValueRecorder.cloneAndRecordCurrentValuesForSceneObject(this); | |||
| clone['_containerWidth'] = this._containerWidth; | |||
There was a problem hiding this comment.
good catch with the missing container width 👍
|
🚀 PR was released in |
This was referenced May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of row repeat fixes grafana/grafana#87539
When changing so that we repeat the first row we are cloning scene query runners that have data and putting them into a new "variable context", but the scene query runners did not detect that variables are different so did not issue new queries.
This changes clone logic of SceneQueryRunner so that it will record the current variable values (Before this only happened on deactivate)
📦 Published PR as canary version:
4.18.0--canary.727.9027841193.0✨ Test out this PR locally via:
npm install @grafana/scenes@4.18.0--canary.727.9027841193.0 # or yarn add @grafana/scenes@4.18.0--canary.727.9027841193.0