More emotionjs migration changes #4362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teodosii
added
pr:no public docs
teodosii
commented
May 21, 2024
| margin-bottom: 20px; | ||
| width: 100%; | ||
|
|
||
| & > li .hover-button { |
There was a problem hiding this comment.
@joeyorlando I'm migrating more code to emotion and have come across this part, can't really figure out where's hover-button coming from as it's not being defined in any of the add responder styles. Do you happen to know where is that coming from? I know you've been working on this stuff
The only hover-button I see is part of the integration display within the routes, but that shouldn't be related to add responders in any way
brojd
reviewed
May 21, 2024
maskin25
reviewed
May 21, 2024
grafana-plugin/src/containers/AddResponders/__snapshots__/AddResponders.test.tsx.snap
Show resolved
Hide resolved
teodosii
force-pushed
the
rares/emotion-migration
branch
from
1085f45
to
540ac1c
Compare
hdhoang
reviewed
Jun 3, 2024
| border: ${theme.colors.border.weak}; | ||
| display: flex; | ||
| flex-direction: column; | ||
| border-radius: ${theme.shape.radius.default}; |
There was a problem hiding this comment.
With grafana 9.4 themes, shape.radius is not defined.
Could you return to fixed value, thanks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
vars.css, specifically tags-related, but not only