Improve error logging #4351
Merged
Improve error logging #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brojd
added
pr:no public docs
teodosii
reviewed
May 20, 2024
|
|
||
| import { getQueryParams, isTopNavbar } from './GrafanaPluginRootPage.helpers'; | ||
|
|
||
| import grafanaGlobalStyle from '!raw-loader!assets/style/grafanaGlobalStyles.css'; | ||
|
|
||
| export const GrafanaPluginRootPage = (props: AppRootProps) => { | ||
| useOnMount(() => { |
There was a problem hiding this comment.
Is there any difference between this and a useEffect with [] params?
There was a problem hiding this comment.
Nope, this super simple hook is just to avoid putting [] as dependency array every time you want effect to run only on mount. And it has explicit naming
teodosii
approved these changes
May 20, 2024
…ll into brojd/improve-error-logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Checklist
pr:no public docsPR label added if not required)release:). These labels dictate how your PR willshow up in the autogenerated release notes.