Spinner: Change spinner icon when prefers-reduced-motion is set
#87641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
area/grafana/ui
ashharrison90
requested review from
joshhunt and
L-M-K-B
and removed request for
a team
|
ok something weird is going on with the but that is definitely not a friday afternoon job 😂 will come back to it on monday 🤓 |
joshhunt
approved these changes
May 13, 2024
| )} | ||
| name={iconName} | ||
| size={size} | ||
| aria-label="loading spinner" |
There was a problem hiding this comment.
While where here should we get rid of this aria-label? 🥺
There was a problem hiding this comment.
does it need replacing with anything or are we just straight removing it? 🤔
There was a problem hiding this comment.
Hmm... after a brief look, about 75% use the spinner without a text label (and so would require a aria-label). Maybe lets just change it to 'loading' for now?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
prefers-reduced-motionis setmatchMediamocks as well since they weren't working correctly 🤷Why do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: