EmptyState: Don't apply animation when prefers-reduced-motion is set
#87638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashharrison90
added
area/grafana/ui
ashharrison90
requested review from
tskarhed and
JoaoSilvaGrafana
and removed request for
a team
joshhunt
reviewed
May 10, 2024
| grotArm?.setAttribute('style', `transform: rotate(${rotation}deg) translateX(${translation}%)`); | ||
| grotMagnifier?.setAttribute('style', `transform: rotate(${rotation}deg) translateX(${translation}%)`); | ||
| }); | ||
| if (window.matchMedia('(prefers-reduced-motion: no-preference)').matches) { |
There was a problem hiding this comment.
Why doesn't this bail immediately, rather than at the very end?
tskarhed
reviewed
May 13, 2024
| const grotArm = svgRef.current?.querySelector('#grot-not-found-arm'); | ||
| const grotMagnifier = svgRef.current?.querySelector('#grot-not-found-magnifier'); | ||
| // only apply animation if no reduced motion preference is set | ||
| if (window.matchMedia('(prefers-reduced-motion: no-preference)').matches) { |
There was a problem hiding this comment.
Suggested change
| if (window.matchMedia('(prefers-reduced-motion: no-preference)').matches) { | |
| if (!window.matchMedia('(prefers-reduced-motion: no-preference)').matches) { | |
| return; |
What about doing an early return instead? ;)
joshhunt
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Why do we need this feature?
Who is this feature for?
Which issue(s) does this PR fix?:
Fixes #
Special notes for your reviewer:
Please check that: