Scenes/Dashboard: Adjust duplication logic to more closely match old architecture #87635
+25
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaydelaney
added
area/dashboard
area/frontend
no-backport
kaydelaney
requested review from
axelavargas,
ivanortegaalba and
dprokop
and removed request for
a team
There was a problem hiding this comment.
Tested it, and it works as expected.
However, I see the inconsistencies with adding a visualization to a dashboard. I'd try to reuse the logic of adding a panel into a dashboard for both places.
@Ijin08 when adding a panel, or duplicating it. Where would you expect to get the added visualization? Below or next to the current panel?
IMO, it seems more natural to add it next to it. If it doesn't fit, then it can go below.
Thoughts?
There was a problem hiding this comment.
I'd add some test for this logic :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures duplicated panel has same size as original panel.
Placement of duplicate panel is adjusted to be to the right of the original panel where possible.