Alerting: Use new endpoints to fetch single GMA rule on view and edit pages #87625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iew-edit-performance
konrad147
changed the title
|
/deploy-to-hg |
|
|
|
/deploy-to-hg |
|
|
|
This is looking really nice. I discussed with @konrad147 already but repeating here:
|
gillesdemey
reviewed
May 23, 2024
| @@ -43,6 +43,7 @@ export const alertingApi = createApi({ | |||
| 'DataSourceSettings', | |||
| 'GrafanaLabels', | |||
| 'CombinedAlertRule', | |||
| 'GrafanaRulerRule', | |||
gillesdemey
added
the
no-changelog
3 tasks
|
/deploy-to-hg |
|
/deploy-to-hg |
|
|
| }: { | ||
| ruleIdentifier: RuleIdentifier; | ||
| }): RequestState<RuleWithLocation> { | ||
| const ruleSource = getRulesSourceFromIdentifier(ruleIdentifier); |
There was a problem hiding this comment.
Do we really need this ruleSource?
We are only using the ruleSource name that it's already included in the ruleIdentifier.
There was a problem hiding this comment.
I'm not the original author of this piece but it looks to be to resolve the rulesSourceName (which is a string) to either grafana or an instance of DataSourceInstanceSettings which we don't have in the rule identifier if I'm not mistaken.
(I do have some experiments set aside that pass the entire data source settings with the rule identifier so we don't have to resolve ad-hoc but this seems like a separate piece of work)
There was a problem hiding this comment.
What I mean is that if you look to this function this ruleSource is not used for anything. It only appears in a check
fayzal-g
reviewed
May 28, 2024
|
/deploy-to-hg |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
In #86845 we added the ability to retrieve the alert rule definition for Grafana-managed rules by a UID.
This PR refactors rule fetching for Grafana-managed rules to use this new endpoint and significantly increase the speed at which we can render the detail view for a single alert rule.
Depends on #88295