Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DashboardScene: Default hoverHeaderOffset to 0 #87561

Merged
merged 2 commits into from
May 14, 2024
Merged

DashboardScene: Default hoverHeaderOffset to 0 #87561

merged 2 commits into from
May 14, 2024

Conversation

Sergej-Vlasov
Copy link
Contributor

Alternative to #87543 that forces hoverHeaderOffset to 0 and removes all complexity around adjusting this offset

Fixes #87495

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@Sergej-Vlasov Sergej-Vlasov added type/bug area/frontend no-changelog Skip including change in changelog/release notes area/scenes internal for issues made by grafanistas labels May 9, 2024
@Sergej-Vlasov Sergej-Vlasov self-assigned this May 9, 2024
@Sergej-Vlasov Sergej-Vlasov requested a review from a team as a code owner May 9, 2024 14:11
@grafana-delivery-bot grafana-delivery-bot bot added this to the 11.1.x milestone May 9, 2024
@Sergej-Vlasov Sergej-Vlasov modified the milestone: 11.1.x May 9, 2024
torkelo
torkelo reviewed May 9, 2024
View reviewed changes
public/app/features/dashboard-scene/scene/LibraryVizPanel.tsx
@@ -65,6 +65,9 @@ export class LibraryVizPanel extends SceneObjectBase<LibraryVizPanelState> {
pluginVersion: libPanelModel.pluginVersion,
displayMode: libPanelModel.transparent ? 'transparent' : undefined,
description: libPanelModel.description,
// To be replaced with it's own option persisted option instead derived
hoverHeader: !libPanelModel.title && !libPanelModel.timeFrom && !libPanelModel.timeShift,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the panel title can be different from lib panel name, is this the dashboard panel title or lib panel name?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is dashboard panel title
Screenshot 2024-05-09 at 17 56 10

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sergej-Vlasov ok great

@Sergej-Vlasov Sergej-Vlasov added the backport v11.0.x Mark PR for automatic backport to v11.0.x label May 14, 2024
@grafana-delivery-bot grafana-delivery-bot
Copy link
Contributor

This PR must be merged before a backport PR will be created.

@Sergej-Vlasov Sergej-Vlasov merged commit 5f14764 into main May 14, 2024
18 checks passed
@Sergej-Vlasov Sergej-Vlasov deleted the serge-scenes-hover-header-offset-0 branch May 14, 2024 14:51
@ephemeral-instances-bot
Copy link

Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs

Error message

handling pull request closed event: deleting instance by slug: unexpected response status: status=502 responseBody=

<title>502 Server Error</title>

Error: Server Error

The server encountered a temporary error and could not complete your request.

Please try again in 30 seconds.

@Sergej-Vlasov Sergej-Vlasov mentioned this pull request May 14, 2024
Closed
3 tasks
grafana-delivery-bot bot pushed a commit that referenced this pull request May 14, 2024
@Sergej-Vlasov @grafana-delivery-bot
DashboardScene: Default hoverHeaderOffset to 0 (#87561)
03d3be0 
* remove hoverHeaderOffsetBehavior and force offset to 0

* force headerHoverOffset in addPanel flow

(cherry picked from commit 5f14764)
@grafana-delivery-bot grafana-delivery-bot bot mentioned this pull request May 14, 2024
Merged
3 tasks
@ephemeral-instances-bot
Copy link

Error building instance: Contact #proj-ephemeral-hg-instances if it is not a compile error. Logs

Error message

handling pull request closed event: deleting instance by slug: unexpected response status: status=502 responseBody=

<title>502 Server Error</title>

Error: Server Error

The server encountered a temporary error and could not complete your request.

Please try again in 30 seconds.

Sergej-Vlasov added a commit that referenced this pull request May 14, 2024
@grafana-delivery-bot @Sergej-Vlasov
[v11.0.x] DashboardScene: Default hoverHeaderOffset to 0 (#87838)
e730ea6 
DashboardScene: Default `hoverHeaderOffset` to 0 (#87561)

* remove hoverHeaderOffsetBehavior and force offset to 0

* force headerHoverOffset in addPanel flow

(cherry picked from commit 5f14764)

Co-authored-by: Sergej-Vlasov <37613182+Sergej-Vlasov@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torkelo torkelo torkelo approved these changes

@axelavargas axelavargas Awaiting requested review from axelavargas

@dprokop dprokop Awaiting requested review from dprokop

@ivanortegaalba ivanortegaalba Awaiting requested review from ivanortegaalba

Assignees

@Sergej-Vlasov Sergej-Vlasov

Labels
area/frontend area/scenes backport v11.0.x Mark PR for automatic backport to v11.0.x internal for issues made by grafanistas no-changelog Skip including change in changelog/release notes type/bug
Projects
Dashboards
Status: 🚀 Done
Milestone
11.1.x
Development

Successfully merging this pull request may close these issues.

DashboardScene: Panel menu crop with hoverHeader in panel view/edit/duplicate/add scenarios
2 participants
@Sergej-Vlasov @torkelo