Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DashboardScene: Panel menu crop with hoverHeader in panel view/edit/duplicate/add scenarios #87495

Closed
Sergej-Vlasov opened this issue May 8, 2024 · 2 comments · Fixed by #87561
Closed

DashboardScene: Panel menu crop with hoverHeader in panel view/edit/duplicate/add scenarios #87495

Sergej-Vlasov opened this issue May 8, 2024 · 2 comments · Fixed by #87561
Assignees
@Sergej-Vlasov
Labels
area/frontend area/scenes internal for issues made by grafanistas team/grafana-dashboards Dashboards squad type/bug
Milestone
11.1.x

Comments

@Sergej-Vlasov
Copy link
Contributor

Sergej-Vlasov commented May 8, 2024 •
edited

in #85780 we did not account for several other scenarios where panel menu can be cropped when hoverHeader is true. These are scenarios that can crop panel menu:

  • panel view
  • panel edit
  • add panel
  • duplicate panel
  • library panels

some of the hover panel menu crop examples (in the video panels with transparent background are library panels):

Screen.Recording.2024-05-09.at.13.41.54.mov
@Sergej-Vlasov Sergej-Vlasov mentioned this issue May 8, 2024
Closed
@Sergej-Vlasov Sergej-Vlasov self-assigned this May 8, 2024
@grafanabot grafanabot added the team/grafana-dashboards Dashboards squad label May 8, 2024
@Sergej-Vlasov Sergej-Vlasov added this to the 11.1.x milestone May 8, 2024
@torkelo
Copy link
Member

torkelo commented May 9, 2024

@Sergej-Vlasov unable to see any cropping in these scenarios

@Sergej-Vlasov Sergej-Vlasov mentioned this issue May 9, 2024
Closed
3 tasks
@Sergej-Vlasov
Copy link
Contributor Author

@torkelo added a video with examples in the description. Here is a PR that fixes all the cases when hover panel menu is cropped.

This was referenced May 9, 2024
Open
Merged
@grafana-delivery-bot grafana-delivery-bot bot mentioned this issue May 14, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Sergej-Vlasov Sergej-Vlasov

Labels
area/frontend area/scenes internal for issues made by grafanistas team/grafana-dashboards Dashboards squad type/bug
Projects
Dashboards
Status: 🚀 Done
Milestone
11.1.x
3 participants
@torkelo @Sergej-Vlasov @grafanabot