Issue / 8735 Update PAX termsAndConditions.notify Response
#8736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otify callback returns empty object.
|
Build files for e7376e4 have been deleted. |
|
Size Change: -1 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
aaemnnosttv
approved these changes
May 20, 2024
aaemnnosttv
reviewed
May 20, 2024
There was a problem hiding this comment.
Thanks @10upsimon – this LGTM there are just a few minor corrections to make in the test
Comment on lines
271
to
272
| describe( 'termsAndConditionsService', () => { | ||
| it( 'notify callback should return an empty object', async () => { |
There was a problem hiding this comment.
The hierarchy has gotten off here, although it works. Let's correct it for consistency.
It should have
- describe service
- - describe method
- - - it ...
termsAndConditionsServiceis missing the inner describe fornotifygetSupportedConversionTrackingTypesis out of place (not nested under its service)
There was a problem hiding this comment.
Addressed in latest commit thanks @aaemnnosttv
Co-authored-by: Evan Mattson <emattson@google.com>
…b.com:google/site-kit-wp into issue/8735-update-pax-t-and-c-notify-response.
aaemnnosttv
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
termsAndConditionsService.notifyFunction Body Being Empty #8735Relevant technical choices
assets/js/modules/ads/pax/services.jstermsAndConditions.notifyfunction body to return empty object,return {};assets/js/modules/ads/pax/services.test.jstermsAndConditionsServiceto assert thattermsAndConditions.notifyreturns an empty objectPR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist