Enhancement/8661 pax success banner #8734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build files for f2f696f have been deleted. |
|
Size Change: +3.37 kB (+0.23%) Total Size: 1.47 MB
ℹ️ View Unchanged
|
tofumatt
requested changes
May 21, 2024
Comment on lines
45
to
54
| event.preventDefault(); | ||
|
|
||
| setTimeout( () => { | ||
| const widgetClass = '.googlesitekit-widget--partnerAdsPAX'; | ||
|
|
||
| global.scrollTo( { | ||
| top: getContextScrollTop( widgetClass, breakpoint ), | ||
| behavior: 'smooth', | ||
| } ); | ||
| }, 50 ); |
There was a problem hiding this comment.
I realise now the ACs are a bit unclear on this, but we should dismiss the notification when either CTA actions are used. I've updated the ACs to clarify this, and we should add a call to setNotification( undefined ); here.
| @@ -61,6 +62,7 @@ | |||
|
|
|||
| .mdc-button { | |||
| margin: 0 auto; | |||
| min-height: 32px; // Default min-height across the plugin is 40px, but in this instance it shouldn't be that big. | |||
There was a problem hiding this comment.
This comment doesn't explain why it should be smaller, just that it should be, but that's already evident by the style declaration 😄
The comment can be removed unless you need/want to explain the reasoning, if it's complicated 🙂
Suggested change
| min-height: 32px; // Default min-height across the plugin is 40px, but in this instance it shouldn't be that big. | |
| min-height: 32px; |
…le/site-kit-wp into enhancement/8661-pax-success-banner.
|
Thanks @tofumatt PR updated |
tofumatt
approved these changes
May 23, 2024
tofumatt
reviewed
May 23, 2024
|
@tofumatt Conflicts fixed. E2E nightly seems to be failing for some unrelated test regarding admin-bar |
tofumatt
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Addresses issue:
Relevant technical choices
show mebutton is not present. The PAX success notification only has stories, but it is not added to the VRT, as that part of the IB test section is crossed.PR Author Checklist
Do not alter or remove anything below. The following sections will be managed by moderators only.
Code Reviewer Checklist
Merge Reviewer Checklist