Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the custom search input partial #1512

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

razonyang
Copy link
Contributor

@razonyang razonyang commented May 7, 2023

This PR exposes a template (empty by default) for customizing the search input, which will be included if all existing search options were disabled.

The purpose of this PR is that avoid overriding the layouts/partials/search-input.html which will make other search options unusable and hard to maintain on users/clients side.

Copy link
Collaborator

@deining deining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

Copy link
Collaborator

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • See inline comment.
  • Also, this new feature should be mentioned in the docs.

layouts/partials/search-input.html Outdated Show resolved Hide resolved
@chalin chalin added this to the 23Q3 milestone May 31, 2023
@chalin chalin modified the milestones: 23Q3, 23Q4 Jul 27, 2023
@chalin chalin modified the milestones: 23Q4, 24Q1 Nov 3, 2023
@chalin chalin modified the milestones: 24Q1, 24Q2 Jan 11, 2024
@chalin chalin modified the milestones: 24Q2, 24Q3 Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants