root: docker-compose: remove version top level element #9631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for authentik-storybook canceled.
|
✅ Deploy Preview for authentik-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
There are other places where we can remove this as like, such as https://docs.goauthentik.io/docs/outposts/manual-deploy-docker-compose |
4d62
force-pushed
the
docker-compose/rm-top-level-element-version
branch
from
8414817
to
2ed5a3d
Compare
I think this should be all of them. Searched with file name instead of something like |
4d62
force-pushed
the
docker-compose/rm-top-level-element-version
branch
from
3483d7a
to
1e8f483
Compare
|
... (forgot to git pull / rebase issues) |
4d62
force-pushed
the
docker-compose/rm-top-level-element-version
branch
from
1e8f483
to
d7e0b27
Compare
4d62
force-pushed
the
docker-compose/rm-top-level-element-version
branch
from
d7e0b27
to
ed214b4
Compare
rissson
approved these changes
May 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9631 +/- ##
==========================================
+ Coverage 92.35% 92.38% +0.03%
==========================================
Files 688 704 +16
Lines 33639 34401 +762
==========================================
+ Hits 31068 31783 +715
- Misses 2571 2618 +47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
BeryJu
changed the title
kensternberg-authentik
added a commit
that referenced
this pull request
May 24, 2024
* main: (36 commits) ci: use container registry for container build cache (#9809) core: bump lxml from 5.2.1 to 5.2.2 (#9717) web: bump mermaid from 10.9.0 to 10.9.1 in /web (#9734) core: bump scim2-filter-parser from 0.5.0 to 0.5.1 (#9730) web: bump core-js from 3.37.0 to 3.37.1 in /web (#9733) stages/authenticator_webauthn: Update FIDO MDS3 & Passkey aaguid blobs (#9729) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh_CN (#9802) translate: Updates for file locale/en/LC_MESSAGES/django.po in zh-Hans (#9803) core: bump sentry-sdk from 2.2.0 to 2.2.1 (#9807) web: bump the storybook group in /web with 7 updates (#9804) web: bump glob from 10.3.15 to 10.3.16 in /web (#9805) root: docker-compose: remove version top level element (#9631) core, web: update translations (#9790) web: bump API Client version (#9801) web/admin: rework initial wizard pages and add grid layout (#9668) website/integrations: discord: fix typo (#9800) website/integration/netbox: fix group custom pipeline example (#9738) root: add primary-replica db router (#9479) website/integrations: add three more policy-expressions to discord-docs (#5760) website/integrations: netbox: add missing scope configuration (#9491) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This pull request removes the version top level element from the docker-compose.yml as it causes an unnecessary warning that can be avoided. See https://github.com/compose-spec/compose-spec/blob/master/04-version-and-name.md
Checklist
ak test authentik/)make lint-fix)If an API change has been made
make gen-build)If changes to the frontend have been made
make web)If applicable
make website)