grc-qt: Variable editor: fix several bugs #7357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Variable editor in grc-qt is an incomplete port of the Variable editor in grc --gtk But as all the functionsof the editor like add/delete/enable/disable block are already coded int the Mainwindow it's sufficient to map this functions from the editor by signal and slot mechanism to the correspondend functions in the Mainwindow. Fixes: gnuradio#7305 Fixes: gnuradio#7306 Fixes: gnuradio#7307 Signed-off-by: Volker Schroer <3470424+dl1ksv@users.noreply.github.com>
willcode
added
ported-to-3.10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Variable editor in grc-qt is an incomplete port of the Variable editor in grc --gtk
But as all the functionsof the editor like add/delete/enable/disable block are already coded int the Mainwindow it's sufficient to map this functions from the editor by signal and slot mechanism to the correspondend functions in the Mainwindow.
Related Issue
Fixes #7305
Fixes #7306
Fixes #7307
Testing Done
Setup several fg's and edit the variables within the variable editor
Checklist