-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a grid to the flowgraph canvas. #6822
base: main
Are you sure you want to change the base?
Conversation
Adds a menu option that allows users to optionally show/hide the grid. Only enables 'lines'. 'Dots' and 'hybrid' are implemented but very slow. Signed-off-by: Seth Hitefield <sdhitefield@gmail.com>
Ah, ok, it's the small snap grid that already exists. |
Yes, it's driven by the same points as snap to grid, so blocks should be aligned. |
Updated Python formating on a couple of files using |
336e113
to
bf2a5fc
Compare
Sounds like a possible additional issue would be to change the block rendering to round up to an integer of the snap grid size? That might improve visual consistency? IIRC the original feature request came from the general chat room and I posted it on their behalf. I do think the grid has some use (defaulting to off) and, aside from the commented out portion, has a small code footprint. |
cr.move_to(0, h_i) | ||
cr.line_to(width, h_i) | ||
cr.stroke() | ||
# elif grid_mode == "dots": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should either leave this in, or delete these lines. I'm for leaving it in, even if it's not obvious how to change it (I don't think this PR needs to add ways to set this through the GUI, for example).
Description
This adds a grid to the flowgraph canvas which can be optionally shown by the user.
Related Issue
Fixes #5672.
Which blocks/areas does this affect?
GRC
Testing Done
Did basic testing to make sure the feature worked as expected.
Checklist