Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust-version #3160

Closed
wants to merge 2 commits into from
Closed

Add rust-version #3160

wants to merge 2 commits into from

Conversation

dahlbaek
Copy link
Contributor

The MSRV added here is the version of rustc currently shipped
with Debian Testing (trixie): https://packages.debian.org/testing/rustc.
This should make it clear (in principle) how to add the gleam compiler
to the main Debian component of the next stable Debian release.

Some tweaks are made to the lockfile in order to support this MSRV.

@dahlbaek dahlbaek changed the title Add msrv Add rust-version May 19, 2024
@dahlbaek dahlbaek mentioned this pull request May 19, 2024
@dahlbaek
Copy link
Contributor Author

closes #3163

@lpil
Copy link
Member

lpil commented May 20, 2024

What's the motivation for this? The only version we officially support is the latest stable. Wouldn't requiring that cause problems for packaging for Debian as they use an older version?

@dahlbaek
Copy link
Contributor Author

dahlbaek commented May 20, 2024

For a binary package, that's a reasonably policy I think. When building, one can always choose to ignore the meta-data (cargo build --ignore-rust-version), but I think the more common case will be that when it's time for a new release, one chooses a version of rustc to package, and then it'll be straightforward to pick the latest release of gleam that supports that version of rustc (via rust-version).

@dahlbaek
Copy link
Contributor Author

dahlbaek commented May 20, 2024

I'm looking into upstreaming small tweaks to the impacted library dependencies so the latest version of them will support rustc 1.71.1

@lpil
Copy link
Member

lpil commented May 20, 2024

then it'll be straightforward to pick the latest release of gleam that supports that version of rustc (via rust-version).

This will result in a very poor experience for users of the Gleam package to the point where I don't believe there's any value in having the package.

@dahlbaek
Copy link
Contributor Author

Following discussion in #3163, I'll close this as well.

@dahlbaek dahlbaek closed this May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants