Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for stock split orders #3211

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Fedron
Copy link
Contributor

@Fedron Fedron commented Mar 30, 2024

Add new order type "SPLIT" to enable tracking stock splits.

  • Allow a negative number in the DTO for just the "SPLIT" order type

Uses the quantity field as the ratio for the stock split:

  • A positive quantity represents a forward stock split (i.e. quantity = 2 = 2 for 1 split)
  • A negative quantity represents a reverse stock split (i.e. quantity = -2 = 1 for 2 split)

The portfolio calculator now also takes in "SPLIT" orders and will update the total quantity of shares accordingly.

@dtslvr
Copy link
Member

dtslvr commented Mar 30, 2024

Thank you for this suggestion, @Fedron. I'm pretty sure it is a useful feature. As the portfolio calculator is currently undergoing a major rebuild, I think it is not the ideal moment to add further complexity.

@Hugo-Persson
Copy link
Contributor

I think this looks like a great suggestion! @dl90 when do you think this can be merged in and released?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants