Feature: Add NetworkManager resource support #7704
Conversation
zkarpinski
changed the title
…pinski/moto into add-network-manager-feature
…com/zkarpinski/moto into add-network-manager-feature" This reverts commit bd56574, reversing changes made to d9bf2da.
There was a problem hiding this comment.
Hi @zkarpinski, thank you for the PR!
Can you merge in the latest master? I've pushed a fix for the Docker-errors this morning, so that should fix the build. Once the build passes, I'll do a proper review.
…pinski/moto into add-network-manager-feature
…pinski/moto into add-network-manager-feature
|
@bblommers Merged the latest master and fixed some issues however I'm not sure what is causing the 404 server error for Tag & Untag. My local tests work as expected. *First contribution to moto |
There was a problem hiding this comment.
This looks great @zkarpinski - thank you so much for adding this!
The failing tests is probably because the URL's need some manual mangling - I'll see if I can fix that now.
|
Hi @zkarpinski, Thank you for contributing to Moto! To show our thanks, we'd like to share some of the donations that we've received with you. PR's like this are the big reason that Moto is as successful as it is - so it's only fair that you, as a contributor, get to share the spoils. We've created a companion website with more information: Feel free to open a bug or discussion if you run into any problems: |
|
This is now part of moto >= 5.0.8.dev18 |
Resolves #7703
Adds support for NetworkManager with the following endpoints