-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add output_file_name parameter. #30
Open
kosyloa
wants to merge
3
commits into
gabrielmittag:master
Choose a base branch
from
kosyloa:master
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmittag
requested changes
Oct 13, 2022
changed |
Oh looks like you missed the quotes around 'output_file_name' |
Fixed. Thx |
Hadlay-Zhang
pushed a commit
to Hadlay-Zhang/NISQA
that referenced
this pull request
Sep 8, 2023
Added new descriptive tools for Speech Quality Prediction: - Mean and Standard Deviation calculations of the predictions - BarCharts and LineCharts of the predictions This change helps provide better assistance especially for Speech Quality Testing, e.x. repeated averaging of results for the same test sample in practical audio testing scenarios. Also, output name of csv is added just like gabrielmittag#30.
Hadlay-Zhang
pushed a commit
to Hadlay-Zhang/NISQA
that referenced
this pull request
Sep 8, 2023
Added descriptive tools for Speech Quality Prediction: - Mean and Standard Deviation of the results - BarChart and LineChart of the results This change helps provide better assistance in Speech Quality Prediction, especially for repeated averaging of results of the same test sample in practical Audio Testing Scenarios. Also, output name of CSV is added just like gabrielmittag#30.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, Gabriel.
I started use your NISQA code.
First of all: thanks a lot for your big work.
I use predict in batch mode with saving results in the same directory.
And I faced with problem: lib uses the same name of file for all evaluation. of course, i can save in different folders.
But I added parameter for output file name. To avoid backward compatibility problems: it is parameter with default value(previous file name which used in your code)