Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(connlib): upgrade domain version from 0.9 to 0.10 #5028

Merged
merged 2 commits into from
May 20, 2024
Merged

chore(connlib): upgrade domain version from 0.9 to 0.10 #5028

merged 2 commits into from
May 20, 2024

Conversation

conectado
Copy link
Collaborator

No description provided.

@vercel Vercel
Copy link

vercel bot commented May 17, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
firezone ⬜️ Ignored (Inspect) Visit Preview May 20, 2024 8:38pm

@github-actions github-actions bot added the kind/chore Issues related to repository cleanup or maintenance label May 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited

Terraform Cloud Plan Output

Plan: 15 to add, 15 to change, 15 to destroy.

Terraform Cloud Plan

@github-actions GitHub Actions
Copy link

github-actions bot commented May 17, 2024 •
edited

Performance Test Results

TCP

Test Name Received/s Sent/s Retransmits
direct-tcp-client2server 245.4 MiB (+3%) 246.8 MiB (+2%) 329 (+24%)
direct-tcp-server2client 242.6 MiB (-1%) 244.4 MiB (-1%) 492 (+125%)
relayed-tcp-client2server 231.1 MiB (+1%) 231.8 MiB (+1%) 257 (-7%)
relayed-tcp-server2client 230.8 MiB (-4%) 231.8 MiB (-4%) 451 (+17%)

UDP

Test Name Total/s Jitter Lost
direct-udp-client2server 500.0 MiB (-0%) 0.02ms (-38%) 42.46% (-1%)
direct-udp-server2client 500.0 MiB (+0%) 0.02ms (+12%) 18.39% (-18%)
relayed-udp-client2server 500.0 MiB (-0%) 0.04ms (+39%) 56.69% (+3%)
relayed-udp-server2client 500.0 MiB (+0%) 0.01ms (-75%) 40.39% (-12%)

thomaseizinger
thomaseizinger approved these changes May 18, 2024
View reviewed changes
Copy link
Member

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Name is a bit too generic.

Approving modulo a better name!

rust/connlib/shared/src/lib.rs Outdated Show resolved Hide resolved
@conectado conectado enabled auto-merge May 20, 2024 20:38
@conectado conectado added this pull request to the merge queue May 20, 2024
Merged via the queue into main with commit 361aafb May 20, 2024
135 checks passed
@conectado conectado deleted the chore/update-domain-version branch May 20, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

@ReactorScram ReactorScram Awaiting requested review from ReactorScram

Assignees
No one assigned
Labels
kind/chore Issues related to repository cleanup or maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@conectado @thomaseizinger