Fix: Visual bug when using selectCurrentPageOnly in combination with grouping #12860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danharrin
requested changes
May 20, 2024
There was a problem hiding this comment.
Can you please refactor this to use a $page argument instead of a random string, like I did in your other PR?
And since we'll be calling $this->getTablePage() in two places, maybe save this value as $page at the top of the index.blade.php file alongside the other variables?
|
If you want to wait until the other PR is merged, then merge that in to here before you make the changes, that's also fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While confirming this another PR worked properly with groups. I noticed when selectCurrentPageOnly is used in combination with grouping it causes a visual bug.
The checkbox would display as checked if none or not all records of that group on the current page are selected.
The code change simply adds a livewire key to the group checkbox component so livewire knows to update it.
Visual changes
Before:
After:
Functional changes
composer cscommand.