feat: log all available addresses if listening host is 0.0.0.0 #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <hello@matteocollina.com>
Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina
changed the title
jsumners
approved these changes
May 20, 2024
metcoder95
approved these changes
May 20, 2024
Co-authored-by: James Sumners <321201+jsumners@users.noreply.github.com> Signed-off-by: Matteo Collina <matteo.collina@gmail.com>
|
Is this backportable to v4? |
|
Seems plausible and reasonable to me. |
|
Coverage is failing |
|
PTAL |
gurgunday
approved these changes
May 21, 2024
|
Does anybody has a clue on: 
|
|
Why not just squash and merge? 
|
|
Because GitHub had an outage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the few problems users have with listening to
0.0.0.0manually is that they see0.0.0.0in their logs.I'm converting it to all interfaces
0.0.0.0correspond to.Checklist
npm run testandnpm run benchmarkand the Code of conduct