Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle re-entry in RuntimeScheduler::executeNowOnTheSameThread #44606

Closed
wants to merge 1 commit into from

Conversation

sammy-SC
Copy link
Contributor

Summary:
changelog: [internal]

Protect RuntimeScheduler::executeNowOnTheSameThread against re-entry to prevent deadlocks.

Differential Revision: D57514317

@facebook-github-bot facebook-github-bot added CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. p: Facebook Partner: Facebook Partner labels May 18, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57514317

@analysis-bot
Copy link

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 19,542,742 -11
android hermes armeabi-v7a n/a --
android hermes x86 n/a --
android hermes x86_64 n/a --
android jsc arm64-v8a 22,912,817 +0
android jsc armeabi-v7a n/a --
android jsc x86 n/a --
android jsc x86_64 n/a --

Base commit: 93c079b
Branch: main

sammy-SC added a commit to sammy-SC/react-native that referenced this pull request May 19, 2024
…ook#44606)

Summary:

changelog: [internal]

Protect RuntimeScheduler::executeNowOnTheSameThread against re-entry to prevent deadlocks.

Differential Revision: D57514317
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57514317

…ook#44606)

Summary:

changelog: [internal]

Protect RuntimeScheduler::executeNowOnTheSameThread against re-entry to prevent deadlocks.

Differential Revision: D57514317
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D57514317

@facebook-github-bot facebook-github-bot added the Merged This PR has been merged. label May 20, 2024
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in 30d7a0f.

Copy link

This pull request was successfully merged by @sammy-SC in 30d7a0f.

When will my fix make it into a release? | How to file a pick request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported Merged This PR has been merged. p: Facebook Partner: Facebook Partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants