-
Notifications
You must be signed in to change notification settings - Fork 19.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: update tests #29730
tests: update tests #29730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM when green
@@ -246,7 +246,7 @@ var Forks = map[string]*params.ChainConfig{ | |||
ArrowGlacierBlock: big.NewInt(0), | |||
GrayGlacierBlock: big.NewInt(0), | |||
}, | |||
"Merge": { | |||
"Paris": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this causes a problem, we can just add Merge
too, so we have them both
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have told testing guys to unify the test data. I am fine with defining both Merge
and Paris
to pass the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed
This pull request pulls the latest changes from tests repo, including the changes for EIP7610 (ethereum/tests#1367)
TODO