Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): EOF - EIP-3540: update validation tests for recent spec #558

Merged
merged 1 commit into from
May 28, 2024

Conversation

chfast
Copy link
Contributor

@chfast chfast commented May 15, 2024

🗒️ Description

  • EOF can have truncated data (these are valid containers).
  • Properly specify non-returning code section.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

- EOF can have truncated data (these are valid containers).
- Properly specify non-returning code section.
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@marioevz marioevz changed the title fix(tests): update EOF validation tests for recent spec fix(tests): EOF - EIP-3540: update validation tests for recent spec May 28, 2024
@marioevz marioevz merged commit 98cb3f0 into ethereum:main May 28, 2024
5 checks passed
@chfast chfast deleted the eof/update_validation branch June 12, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants