Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Token standards IA refactor #12983

Merged
merged 3 commits into from
May 30, 2024
Merged

Token standards IA refactor #12983

merged 3 commits into from
May 30, 2024

Conversation

corwintines
Copy link
Member

Description

  • Refactor IA for token standards
  • Add information on known issues for ERC-20
  • Setup foundation for linking out to other fungible token standards from ERC-20 page

@github-actions github-actions bot added content 🖋️ This involves copy additions or edits needs review 👀 labels May 19, 2024
@netlify Netlify
Copy link

netlify bot commented May 19, 2024 •
edited

✅ Deploy Preview for ethereumorg ready!

Name Link
🔨 Latest commit 4375f3b
🔍 Latest deploy log https://app.netlify.com/sites/ethereumorg/deploys/6658893eaa93c400085b4b2c
😎 Deploy Preview https://deploy-preview-12983--ethereumorg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 7 paths audited
Performance: 47 (🟢 up 9 from production)
Accessibility: 92 (no change from production)
Best Practices: 89 (🔴 down 3 from production)
SEO: 93 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

minimalsm
minimalsm reviewed May 28, 2024
View reviewed changes
src/data/placeholders/content-developers-docs-standards-tokens-erc-4626-data.json
@@ -0,0 +1,6 @@
{
"/content/developers/docs/standards/tokens/erc-4626/map-of-erc-4626.png": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@corwintines whats going on here 🤔 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its used for image placeholders. Sometimes this gets missed on commits since its done during build time.

minimalsm
minimalsm approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@minimalsm minimalsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @corwintines !

@corwintines corwintines merged commit c711cb8 into dev May 30, 2024
6 checks passed
@corwintines corwintines deleted the tokenContentStructure branch May 30, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minimalsm minimalsm minimalsm approved these changes

@wackerow wackerow Awaiting requested review from wackerow wackerow is a code owner

@pettinarip pettinarip Awaiting requested review from pettinarip pettinarip is a code owner

@nhsz nhsz Awaiting requested review from nhsz nhsz is a code owner

Assignees
No one assigned
Labels
content 🖋️ This involves copy additions or edits
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corwintines @minimalsm @wackerow