refactor(layouts): create story and update style for base layout #12960
+83
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerAPfledderer
requested review from
wackerow,
corwintines,
pettinarip,
minimalsm and
nhsz
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
github-actions
bot
added
content 🖋️
pettinarip
reviewed
May 31, 2024
src/layouts/BaseLayout.tsx
Outdated
| {children} | ||
|
|
||
| <Footer lastDeployDate={lastDeployDate} /> | ||
| <Container maxW="1536px"> |
There was a problem hiding this comment.
can't we use a theme value?
Suggested change
| <Container maxW="1536px"> | |
| <Container maxW="container.2xl"> |
There was a problem hiding this comment.
@pettinarip Hmm that token is set to 1440px which is not the width shown in figma. Should we increase the value to 1536px or add container.3xl?
There was a problem hiding this comment.
shouldn't the folder be named just stories? to avoid the redundancy.
There was a problem hiding this comment.
No problem!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create a story for
RootLayout, now namedBaseLayoutto be in sync with naming in the DS.Also makes slight layout adjustments to adhere to the DS.