Increase sync watchers period to 1 second #17583
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
serathius
force-pushed
the
sync-watchers-1s
branch
from
60db295
to
ab70c02
Compare
|
Propose to add a config item, which defaults to 1s in main branch, and defaults to 100ms in the stable releases to keep the existing behaviour by default. |
This is a simple change. If there is no any objection, we can delegate the change to other contributor to share your load. |
|
Right, with K8s mitigation to stop sending watch to etcd, I don't think it's critical for now. Leaving it for someone to pick up. |
jmhbnz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #16839