fileutil: improve control flow readability of purgeFile function #17564
Conversation
Signed-off-by: redwrasse <mail@redwrasse.io>
|
Hi @redwrasse. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
client/pkg/fileutil/purge.go
Outdated
| @@ -53,26 +52,35 @@ func purgeFile(lg *zap.Logger, dirname string, suffix string, max uint, interval | |||
| zap.Uint("max", max), | |||
| zap.Duration("interval", interval)) | |||
|
|
|||
| readDirWithSuffix := func(dirname string) ([]string, error) { | |||
There was a problem hiding this comment.
Why not have it as normal function (defined outside of other functions body) instead of anonymous one?
There was a problem hiding this comment.
No need to have an anonymous function, agreed. Do you suggest adding as a separate function in purge.go?
There was a problem hiding this comment.
converted to a normal function in purge.go. this is a little awkward though as it should properly probably be part of read_dir.go.
Signed-off-by: redwrasse <mail@redwrasse.io>
redwrasse
force-pushed
the
redwrasse/purge-fnames-logic
branch
from
c35aecb
to
6cf5419
Compare
|
/retest |
|
cc @serathius |
PR for issue #17565
Proposed improvement to syntax for control flow of
purgeFilefunction inclient/pkg/fileutil/purge.go.fnamesWithSufixthat remains unmodified.nPurgedvariable introduced for for loop in go routine, and for counting writes topurgeCchannel.ReadDirmethod reads directory filenames in sorted order, and sorted order is preserved after suffix filtering.