Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid problem during averaging when parameter-tying exists #5533

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tzyll
Copy link

@tzyll tzyll commented Nov 6, 2023

Why?

When parameter-tying exists in a pytorch network, different keys share the same memory which will be processed multiple times if not separated using clone().

@sw005320 sw005320 added the Bugfix label Nov 6, 2023
@sw005320 sw005320 added this to the v.202312 milestone Nov 6, 2023
@sw005320
Copy link
Contributor

sw005320 commented Nov 6, 2023

Will it break the compatibility, or can we still use the old model checkpoint?

@tzyll
Copy link
Author

tzyll commented Nov 7, 2023

Hi, the modification won't affect the old model checkpoint.

Will it break the compatibility, or can we still use the old model checkpoint?

@sw005320
Copy link
Contributor

sw005320 commented Nov 7, 2023

Thanks!
One more request.
Could you show me that the old one and this do not change the results (model parameters themselves and ASR results)?

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #5533 (e50da1c) into master (0d0ab98) will decrease coverage by 1.06%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5533      +/-   ##
==========================================
- Coverage   70.31%   69.25%   -1.06%     
==========================================
  Files         711      710       -1     
  Lines       65757    65670      -87     
==========================================
- Hits        46237    45481     -756     
- Misses      19520    20189     +669     
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (?)
test_integration_espnet1 63.02% <ø> (?)
test_integration_espnet2 48.61% <ø> (ø)
test_python_espnet1 ?
test_python_espnet2 51.39% <ø> (+0.03%) ⬆️
test_utils 22.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 147 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@kan-bayashi kan-bayashi modified the milestones: v.202312, v.202405 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants