Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sentencepiece version for Python 3.11 #5532

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fujimotos
Copy link
Contributor

What?

This patch fixes the version specifier for sentencepiece in setup.py.

Why?

SentencePiece adds support for Python 3.11 in v0.1.98.

https://github.com/google/sentencepiece/releases/tag/v0.1.98

Since ESPnet pins sentencepiece to v0.1.97, users with recent Python version can
see failure during installation.

Note: We received such a bug report today from a user who uses Python 3.11.5,
so proceeded to submit this patch.

See also

SentencePiece adds support for Python 3.11 in v0.1.98.

> https://github.com/google/sentencepiece/releases/tag/v0.1.98

Since ESPnet pins sentencepiece to v0.1.97, users with newer Python
version can see failure during installation. Fix it thusly.

Signed-off-by: Fujimoto Seiji <fujimoto@ceptord.net>
@mergify mergify bot added the Installation label Nov 6, 2023
@sw005320 sw005320 added the Bugfix label Nov 6, 2023
@sw005320 sw005320 added this to the v.202312 milestone Nov 6, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (96978d4) 76.12% compared to head (f94df3a) 59.71%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #5532       +/-   ##
===========================================
- Coverage   76.12%   59.71%   -16.42%     
===========================================
  Files         743      742        -1     
  Lines       69126    69039       -87     
===========================================
- Hits        52622    41225    -11397     
- Misses      16504    27814    +11310     
Flag Coverage Δ
test_configuration_espnet2 ∅ <ø> (∅)
test_integration_espnet1 ?
test_integration_espnet2 48.49% <ø> (ø)
test_python_espnet1 ?
test_python_espnet2 52.65% <ø> (ø)
test_utils 22.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kamo-naoyuki
Copy link
Collaborator

kamo-naoyuki commented Nov 10, 2023

Sentencepiece v0.1.98 seems to break backward compatibility.
I don't know the details of the update. Please ask someone in the know.

@kan-bayashi kan-bayashi modified the milestones: v.202312, v.202405 Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants