-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make SPI Ethernet (W5500) compatible with ESP-IDF v5 #6778
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6778 +/- ##
==========================================
+ Coverage 53.70% 54.13% +0.42%
==========================================
Files 50 50
Lines 9408 9619 +211
Branches 1654 1698 +44
==========================================
+ Hits 5053 5207 +154
- Misses 4056 4086 +30
- Partials 299 326 +27 ☔ View full report in Codecov by Sentry. |
@fightforlife let's use your branch. 😄 I pushed the couple additional tweaks I had in my branch -- care to give it a quick test? |
I've confirmed this works on my W5500 board with an ESP32 Devkit board. |
What does this implement/fix?
Currently the SPI Ethernet implementation for W5500 is not compatible with ESP-IDF v5 since there were 2 breaking changes from 4.x.x to 5.x.x.
This small PR fixes this.
Types of changes
Related issue or feature (if applicable): I did not create a bug ticket for this.
Pull request in esphome-docs with documentation (if applicable): No change in docs
Test Environment
Example entry for
config.yaml
:Checklist:
tests/
folder).If user exposed functionality or configuration variables are added/changed: