-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect and prefer system-provided service #1038
base: dev
Are you sure you want to change the base?
Conversation
2253984
to
cc5892f
Compare
Rebased on dev instead |
Hey @Scrumplex , Thank you for the help! This is super helpful! Please bear with me for delays in the review, I'm going through the busiest period of my life and I only have limited capacity for OS at the moment. I'll get back to you as soon as I can, I hope you'll understand :) Cheers :) |
Hey!
Did I understand correctly? Cheers :) |
cc5892f
to
c0594b1
Compare
Instead of always creating our own service file for the user, detect if there is a service already present, and skip installing our own service file.
Doesn't really matter, as systemd aliases <service-name> to <service-name>.service anyway. But it's good practice to use the full unit name.
c0594b1
to
eacf34d
Compare
Rebased on dev. So the problem is the following: On a fresh installation of the AUR package, the service file will be installed for all user environments, but will be disabled by default. Now, if I try to run |
By the way: I kinda forgot about this PR 👀 |
Hi! I believe this changes are still relevant to the date |
Some distributions might choose to package the user service as well. For example the AUR packages take the template in the repo, replace the binary path and install it to
/usr/lib/systemd/user/espanso.service
. To keep the systemd environment of users of those packages clean, we should first check if a service already exists.