Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: no-js dark theme bugs #519

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amareshsm
Copy link
Member

Prerequisites checklist

What is the purpose of this pull request?

What changes did you make? (Give an overview)

similar to eslint/eslint#18071

Before After
image image
image image
image image
image image
image image

Related Issues

Is there anything you'd like reviewers to focus on?

I have addressed the identified issues. Feel free to add if anything missing.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for new-eslint ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 3afbf78
🔍 Latest deploy log https://app.netlify.com/sites/new-eslint/deploys/65bd2605f7cdb50008b79af7
😎 Deploy Preview https://deploy-preview-519--new-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@eslint-github-bot eslint-github-bot bot added the bug Something isn't working label Feb 2, 2024
Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for ja-eslint ready!

Name Link
🔨 Latest commit 3afbf78
🔍 Latest deploy log https://app.netlify.com/sites/ja-eslint/deploys/65bd26059644150008b06ba9
😎 Deploy Preview https://deploy-preview-519--ja-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for zh-hans-eslint ready!

Name Link
🔨 Latest commit 3afbf78
🔍 Latest deploy log https://app.netlify.com/sites/zh-hans-eslint/deploys/65bd260513a904000824f46e
😎 Deploy Preview https://deploy-preview-519--zh-hans-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for fr-eslint ready!

Name Link
🔨 Latest commit 3afbf78
🔍 Latest deploy log https://app.netlify.com/sites/fr-eslint/deploys/65bd2605cd30e80009383e42
😎 Deploy Preview https://deploy-preview-519--fr-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for hi-eslint ready!

Name Link
🔨 Latest commit 3afbf78
🔍 Latest deploy log https://app.netlify.com/sites/hi-eslint/deploys/65bd2605e7287d00080549fb
😎 Deploy Preview https://deploy-preview-519--hi-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for de-eslint ready!

Name Link
🔨 Latest commit 3afbf78
🔍 Latest deploy log https://app.netlify.com/sites/de-eslint/deploys/65bd2605975c420008f43daa
😎 Deploy Preview https://deploy-preview-519--de-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for pt-br-eslint ready!

Name Link
🔨 Latest commit 3afbf78
🔍 Latest deploy log https://app.netlify.com/sites/pt-br-eslint/deploys/65bd2605df270b0008b14037
😎 Deploy Preview https://deploy-preview-519--pt-br-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 2, 2024

Deploy Preview for es-eslint ready!

Name Link
🔨 Latest commit 3afbf78
🔍 Latest deploy log https://app.netlify.com/sites/es-eslint/deploys/65bd2605c36dd30008dd51cd
😎 Deploy Preview https://deploy-preview-519--es-eslint.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@amareshsm amareshsm marked this pull request as draft February 4, 2024 13:33
@nzakas
Copy link
Member

nzakas commented Feb 14, 2024

@amareshsm this is still marked as a draft. Is it ready for review?

@harish-sethuraman
Copy link
Member

What is pending here? I can help pushing it to completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Implementing
Development

Successfully merging this pull request may close these issues.

None yet

3 participants