Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic proxy: fix possible infinite loop #34245

Merged
merged 2 commits into from
May 22, 2024

Conversation

wbpcode
Copy link
Member

@wbpcode wbpcode commented May 20, 2024

generic proxy: fix possible infinite loop

Commit Message: generic proxy: fix possible infinite loop
Additional Description:

The generic proxy will fall in infinite loop when the upstream connection is bound to downstream connection and the upstream request is reset because protocol error (or some other reasons), then the generic proxy router will fall in infinite loop because it can never complete the cleaning up of upstream request list.

Risk Level: low.
Testing: unit.
Docs Changes: n/a.
Release Notes: n/a.
Platform Specific Features: n/a.

wbpcode added 2 commits May 18, 2024 12:58
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
@wbpcode
Copy link
Member Author

wbpcode commented May 20, 2024

@zuercher kind ping for a blind approve for this contrib only change.

@wbpcode wbpcode merged commit 2e055e4 into envoyproxy:main May 22, 2024
51 checks passed
@wbpcode wbpcode deleted the dev-fix-generic-proxy branch May 22, 2024 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants