Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle "part_of_explicit_cast" + "cannot overflow" #818

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

handle "part_of_explicit_cast" + "cannot overflow" #818

wants to merge 1 commit into from

Conversation

tgulacsi
Copy link

@tgulacsi tgulacsi commented Mar 1, 2019

And better panic message (use %q to separate regexp from line).


This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 1, 2019

Codecov Report

Merging #818 into master will increase coverage by <.01%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #818      +/-   ##
=========================================
+ Coverage    79.9%   79.9%   +<.01%     
=========================================
  Files         169     169              
  Lines        9793    9794       +1     
=========================================
+ Hits         7825    7826       +1     
  Misses       1503    1503              
  Partials      465     465
Impacted Files Coverage Δ
ast/ast.go 98.34% <0%> (ø) ⬆️
ast/implicit_cast_expr.go 100% <100%> (ø) ⬆️
ast/unary_operator.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 226049e...199b1d6. Read the comment docs.

Copy link
Owner

@elliotchance elliotchance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @tgulacsi)


ast/implicit_cast_expr.go, line 21 at r1 (raw file):

		 '(?P<type>[^']*?)'
		(:'(?P<type2>[^']*?)')?
		 <(?P<kind>[^>]*)>( part_of_explicit_cast)?`,

Did you hit a panic for these cases? It would be great if you could put those panics as unit tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants